gh-111789: Use PyDict_GetItemRef() in sqlite #111829
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serhiy-storchaka
commented
Nov 7, 2023
Modules/_sqlite/cursor.c
Outdated
| current_param = PyObject_GetItem(parameters, binding_name_obj); | ||
| } | ||
| PyObject *current_param; | ||
| (void)PyMapping_GetOptionalItem(parameters, binding_name_obj, ¤t_param); |
There was a problem hiding this comment.
PyMapping_GetOptionalItem() includes a special case for dict, so there is no performance loss.
serhiy-storchaka
requested review from
berkerpeksag and
erlend-aasland
as code owners
erlend-aasland
approved these changes
Nov 10, 2023
|
It can be even more simplified if use |
aisk
pushed a commit
to aisk/cpython
that referenced
this pull request
Feb 11, 2024
Use new C API functions PyDict_GetItemRef() and PyMapping_GetOptionalItemString().
Glyphack
pushed a commit
to Glyphack/cpython
that referenced
this pull request
Sep 2, 2024
Use new C API functions PyDict_GetItemRef() and PyMapping_GetOptionalItemString().
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.